Repository navigation
fix(@angular/build): pass an explicit port of 0 through to the dev server - #34686
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…rver Previously, requesting an ephemeral port (`--port 0`) was resolved by binding a throwaway net.Server to learn the real port before handing that concrete number to Vite or webpack-dev-server, which then bound it again. This avoided a Vite bug where `server.port: 0` was ignored and the default port (5173) was used instead. That bug is fixed upstream (vitejs/vite#7529, vitejs/vite#23158), and webpack-dev-server has always bound port 0 correctly via Node's own http.Server. Pass 0 straight through instead of pre-resolving it, removing the redundant double-bind. Verified via the existing port_spec.ts "random free port" test for both the Vite-based and webpack-based dev server, which covers this exact scenario.
MeAkib
force-pushed
the
fix/dev-server-port-zero
branch
from
November 11, 2026 14:20
5b3d233 to
4b29a1b
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, requesting an ephemeral port (
--port 0) was resolved by binding a throwaway net.Server to learn the real port before handing that concrete number to Vite or webpack-dev-server, which then bound it again. This avoided a Vite bug whereserver.port: 0was ignored and the default port (5173) was used instead.That bug is fixed upstream (vitejs/vite#7529, vitejs/vite#23158), and webpack-dev-server has always bound port 0 correctly via Node's own http.Server. Pass 0 straight through instead of pre-resolving it, removing the redundant double-bind.
Verified via the existing port_spec.ts "random free port" test for both the Vite-based and webpack-based dev server, which covers this exact scenario.